jasonliu marked 3 inline comments as done. jasonliu added inline comments.
================ Comment at: clang/lib/CodeGen/BackendUtil.cpp:1470 + case Triple::XCOFF: + // TODO: Falling through for XCOFF format for now. + break; ---------------- JDevlieghere wrote: > This is confusing, you say fall through but you break? I would prefer a > `llvm_unreachable("XCOFF not yet implemented");` here and elsewhere in this > patch. > Thanks for the comment. Will address in next revision. ================ Comment at: clang/lib/CodeGen/BackendUtil.cpp:1486 + case Triple::XCOFF: + // TODO: Falling through for XCOFF format for now. + break; ---------------- JDevlieghere wrote: > See previous comment. Will address in next revision. ================ Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4410 + case llvm::Triple::XCOFF: + llvm_unreachable("to be determined for XCOFF format"); case llvm::Triple::COFF: ---------------- JDevlieghere wrote: > See previous comment. Will address in next revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58930/new/ https://reviews.llvm.org/D58930 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits