clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
As long as there is not a large performance regress when parsing large DWARF
files this looks good to me. Abbreviation declarations are small, so I don't
expect one.
================
Comment at:
lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.cpp:37-42
+ if (m_tag == DW_TAG_null) {
+ // FIXME: According to the DWARF spec this may actually be malformed.
+ // Should this return an error instead?
+ return DWARFEnumState::Complete;
+ }
+
----------------
Seems like this would be malformed and should be an error. Something about NULL
tag when valid tag was expected
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59370/new/
https://reviews.llvm.org/D59370
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
