On Thu, Mar 14, 2019 at 11:48 AM Greg Clayton via Phabricator <
revi...@reviews.llvm.org> wrote:
> clayborg accepted this revision.
> clayborg added a comment.
> This revision is now accepted and ready to land.
>
> As long as there is not a large performance regress when parsing large
> DWARF files this looks good to me. Abbreviation declarations are small, so
> I don't expect one.
>
>
>
> ================
> Comment at:
> lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.cpp:37-42
> + if (m_tag == DW_TAG_null) {
> + // FIXME: According to the DWARF spec this may actually be malformed.
> + // Should this return an error instead?
> + return DWARFEnumState::Complete;
> + }
> +
> ----------------
> Seems like this would be malformed and should be an error. Something about
> NULL tag when valid tag was expected
>
Forgot to address this before submitting. Will do so in a followup.
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
