labath added a comment. In D60172#1455767 <https://reviews.llvm.org/D60172#1455767>, @jasonmolenda wrote:
> Thanks Pavel, I'll convert this to use Expected<> while I'm working on it. > I'm writing a test case right now, and looking at how DynamicPluginDarwin > works more closely for adding & removing binaries, e.g. there's also no way > to batch remove libraries and have a group broadcast notification be sent. > There was also a bug in my original patch for calling > LoadScriptingResourceForModule() to find a python resource file in a dSYM > bundle - it is currently called from Target::ModuleUpdated when a binary is > added to the target's ModuleList, but I'm suppressing that call with this > change, so I need to move that over to ModulesDidLoad. Sounds good to me. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60172/new/ https://reviews.llvm.org/D60172 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
