probinson added a comment.

In D61611#1496580 <https://reviews.llvm.org/D61611#1496580>, @sgraenitz wrote:

> @stella.stamenova Can you have a look at the lit test please? It works on 
> macOS and Linux, but I didn't test Windows. Should I add something like `# 
> REQUIRES: nowindows` or is it fine like this?


Sorry for the drive-by... what is this `REQUIRES: nowindows`?  I don't see 
where lit generates this property.  I grepped all of llvm-project.git and I see 
it used in two tests, but not where it's produced. Which suggests that those 
tests don't actually run *anywhere*.
I think maybe you want `UNSUPPORTED: system-windows` instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61611/new/

https://reviews.llvm.org/D61611



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to