labath added a comment.

In D61611#1496838 <https://reviews.llvm.org/D61611#1496838>, @probinson wrote:

> @stella.stamenova I'm not familiar with any lit feature that gives a special 
> meaning to the prefix "no".  The opposite of "REQUIRES: windows" is not 
> "REQUIRES: nowindows" but "UNSUPPORTED: windows" AFAIK.
>  This part of the discussion should probably be taken to llvm-dev, though.


There's a `binary_feature` function in `utils/lit/lit/llvm/config.py`, but it's 
only used in a handful of cases. And yeah, I would generally prefer 
`UNSUPPORTED: XYZ` over `REQUIRES: noXYZ`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61611/new/

https://reviews.llvm.org/D61611



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to