aganea added inline comments.
================
Comment at:
source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:29
+ llvm::codeview::CPUType cpu_type;
+ if (arch_type == llvm::Triple::ArchType::aarch64) {
+ cpu_type = llvm::codeview::CPUType::ARM64;
----------------
Shouldn’t ArchType::aarch64_be and ArchType::aarch64_32 enums be handled here
as well?
================
Comment at:
source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:32
+ } else {
+ cpu_type = llvm::codeview::CPUType::X64;
+ }
----------------
Intel80386 for consistency?
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62772/new/
https://reviews.llvm.org/D62772
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
