TomTan marked an inline comment as done.
TomTan added inline comments.
================
Comment at:
source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:29
+ llvm::codeview::CPUType cpu_type;
+ if (arch_type == llvm::Triple::ArchType::aarch64) {
+ cpu_type = llvm::codeview::CPUType::ARM64;
----------------
compnerd wrote:
> aganea wrote:
> > Shouldn’t ArchType::aarch64_be and ArchType::aarch64_32 enums be handled
> > here as well?
> I think that we should use a `switch` to cover the targets. `/Oy` will allow
> FPO on x86 as well. There is also WoA (ARM32).
Seems no, aarch64_be or aarch64_32 is not supported by CodeView or Windows.
================
Comment at:
source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:32
+ } else {
+ cpu_type = llvm::codeview::CPUType::X64;
+ }
----------------
aganea wrote:
> Intel80386 for consistency?
x86 and x64 are handled as the same `CPUType` by CodeView. LLVM pdb dump tool
also sets X64 as default.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62772/new/
https://reviews.llvm.org/D62772
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
