friss added inline comments.

================
Comment at: source/Symbol/CompileUnit.cpp:101
+  // m_functions_by_uid is filled in lazily but we need all the entries.
+  symbol_file->ParseFunctions(*this);
+
----------------
friss wrote:
> This seems pretty expensive. Can we Force the parsing of the functions just 
> in the compiler unit rather than the whole symbol file? If you are using a 
> dSYM, then this is going to load all the debug information in one go.
Sorry, I somehow missed that this takes a CU as argument. This seems fine.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69913/new/

https://reviews.llvm.org/D69913



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to