aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land.
Seems fine otherwise, I think. ================ Comment at: include/lldb/Symbol/CompileUnit.h:174 + lldb::FunctionSP + FindFunction(llvm::function_ref<bool(const llvm::StringRef)> matching_lambda); + ---------------- perhaps calling it `is_match` makes this more obvious? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69913/new/ https://reviews.llvm.org/D69913 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits