labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
This looks fine to me now. Thanks for your patience. ================ Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.h:43-46 + llvm::Expected<std::string> FormatQuoted(llvm::StringRef str); std::mutex m_mutex; lua_State *m_lua_state; + llvm::StringSet<> m_loaded_modules; ---------------- labath wrote: > I guess these are not needed anymore... The FormatQuoted declaration can go too... ================ Comment at: lldb/test/Shell/ScriptInterpreter/Lua/command_script_import.test:2 +# REQUIRES: lua +# RUN: %lldb --script-language lua -o 'command script import %S/Inputs/testmodule.lua' -o 'script testmodule.foo()' 2>&1 | FileCheck %s +# CHECK: Hello World! ---------------- Maybe additionally try to load a nonexisting module? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71825/new/ https://reviews.llvm.org/D71825 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits