labath added inline comments.

================
Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp:46
+  int error = luaL_loadfile(m_lua_state, filename.data()) ||
+              lua_pcall(m_lua_state, 0, LUA_MULTRET, 0);
+  if (error) {
----------------
It would be better to put `1` here instead `LUA_MULTRET`, to ensure we don't 
end up with an unbalanced stack if the module happens to return more than one 
value...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71825/new/

https://reviews.llvm.org/D71825



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to