aprantl added a comment. This is great!
================ Comment at: lldb/docs/resources/test.rst:15 + line. These tests interact with the debugger either through the command line + driver or though ``lldb-test`` which is binary that exposes the internal data + structures in an easy-to-parse way for testing. Most people will know these ---------------- th*r*ough what does "which is binary" mean? ================ Comment at: lldb/docs/resources/test.rst:32 + +Unit tests are localted under ``lldb/unittests``. If it's possible to test +something in isolation or as a single unit, you should make it a unit test. ---------------- located ================ Comment at: lldb/docs/resources/test.rst:70 +while shell tests are limited to single lines of shell commands with compiler +and linker invocations. + ---------------- We should also mention that the API tests will build the inferior for many different configurations ================ Comment at: lldb/docs/resources/test.rst:90 +the tests are structured as a binary begin debugged, so there will be one or +more sources file and a Makefile. ---------------- mention that these are end-to-end tests that compile programs from source, run them, and debug the processes? ================ Comment at: lldb/docs/resources/test.rst:97 + ├── TestSampleTest.py + └── main.c + ---------------- mention that there is an an actual, literal, example test, too? ================ Comment at: lldb/docs/resources/test.rst:145 +focused tests. So relying on it to test say DWARF5 is a really bad idea. +Instead you should write tests that check the specific DWARF5 feature, and +have the variant as a nice-to-have. ---------------- double space CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78242/new/ https://reviews.llvm.org/D78242 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits