vsk accepted this revision. vsk added inline comments. This revision is now accepted and ready to land.
================ Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:135 + ifeq "$(TRIPLE_ENV)" "" + CODESIGN := codesign + endif ---------------- aprantl wrote: > vsk wrote: > > If I've read this correctly, this means we'll only sign when `TRIPLE_OS == > > "macosx" && TRIPLE_ENV == ""`. Is that what we want, or should we be > > signing everything? > This is preserving the old behavior, and IIUC code signing on macOS is just > slowing things down with no advantage. Oh I see. We actually need this change to make sure things for watch/tv get signed. Earlier, I misread `ifneq "$(TRIPLE_OS)" "macosx"` as `ifeq "$(TRIPLE_OS)" "macosx"`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81980/new/ https://reviews.llvm.org/D81980 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
