gedatsu217 added a comment.

> So the way the issue with the single space is now solved is by doing 
> CC_REDISPLAY when we're only adding the single space? Isn't that also 
> deleting the whole autosuggestion?

Yes. CC_REDISPLAY can delete all the gray characters left.



================
Comment at: lldb/source/Host/common/Editline.cpp:1081
+    if (spaces_to_print > 0) {
+      std::string spaces = std::string((int)spaces_to_print, ' ');
+      fputs(spaces.c_str(), m_output_file);
----------------
teemperor wrote:
> The `(int)` cast isn't necessary.
I found that lldb crashed. Sorry, I should have checked more when I uploaded 
this.

I use spaces_to_print as size_t, but this sometimes becomes less than zero. So, 
I have to use this as int.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81001/new/

https://reviews.llvm.org/D81001

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to