teemperor requested changes to this revision. teemperor added inline comments. This revision now requires changes to proceed.
================ Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1525 + // If the SDK type is for the host OS, use its version number. + auto get_host_os = []() { return HostInfo::GetTargetTriple().getOS(); }; switch (sdk_type) { ---------------- `Triple::OSType host_os = HostInfo::GetTargetTriple().getOS();` ? ================ Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1576 + case XcodeSDK::Type::AppleTVOS: + minimum_version_option.PutCString(opt_mtvos_simulator_version_min_EQ); break; ---------------- `opt_mtvos_version_min_EQ` ================ Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1585 + case XcodeSDK::Type::bridgeOS: + minimum_version_option.PutCString(opt_mwatchos_version_min_EQ); + break; ---------------- If this is on purpose, then I think there should be a comment explaining why this is not `-mbridgeos-version-min=` ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89428/new/ https://reviews.llvm.org/D89428 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits