mgorny added inline comments.
================ Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:3562-3567 + (process_features & NativeProcessProtocol::Extension::fork) == + NativeProcessProtocol::Extension::fork) + m_fork_events_supported = true; + else if (x == "vfork-events+" && + (process_features & NativeProcessProtocol::Extension::vfork) == + NativeProcessProtocol::Extension::vfork) ---------------- labath wrote: > Maybe drop the `== Extension::[v]fork` part? Can't do that, `enum class` doesn't convert to `bool`. In fact, I tried a few more or less crazy ideas to make this work, and none worked ;-). ================ Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h:102-103 + bool m_fork_events_supported = false; + bool m_vfork_events_supported = false; + ---------------- labath wrote: > I am wondering if this should just be `NativeProcessProtocol::Extension > m_enabled_extensions;` Can we think of an extension that would belong to > `NativeProcessProtocol::Extension`, but we would not want to store its state > in the GDBRemoteCommunicationServerLLGS class? I can't think of any right now and I suppose even if there were one, there would probably be no big loss in using `Extension` here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100153/new/ https://reviews.llvm.org/D100153 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
