[Lldb-commits] [PATCH] D104231: [lldb] Deprecate the threading functionality in SBHostOS

[Raphael Isemann via Phabricator via lldb-commits]

teemperor updated this revision to Diff 351882.
teemperor added a comment.
Herald added a subscriber: JDevlieghere.

- Remove the deprecation attribute that got inserted by accident.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104231/new/

https://reviews.llvm.org/D104231

Files:
  lldb/bindings/interface/SBHostOS.i
  lldb/include/lldb/API/SBHostOS.h


Index: lldb/include/lldb/API/SBHostOS.h
===================================================================
--- lldb/include/lldb/API/SBHostOS.h
+++ lldb/include/lldb/API/SBHostOS.h
@@ -24,15 +24,21 @@
 
   static lldb::SBFileSpec GetUserHomeDirectory();
 
+  /// \deprecated Deprecated since LLDB version 13.
   static void ThreadCreated(const char *name);
 
+  /// \deprecated Deprecated since LLDB version 13.
   static lldb::thread_t ThreadCreate(const char *name,
                                      lldb::thread_func_t thread_function,
                                      void *thread_arg, lldb::SBError *err);
 
+  /// \deprecated Deprecated since LLDB version 13.
   static bool ThreadCancel(lldb::thread_t thread, lldb::SBError *err);
 
+  /// \deprecated Deprecated since LLDB version 13.
   static bool ThreadDetach(lldb::thread_t thread, lldb::SBError *err);
+
+  /// \deprecated Deprecated since LLDB version 13.
   static bool ThreadJoin(lldb::thread_t thread, lldb::thread_result_t *result,
                          lldb::SBError *err);
 
Index: lldb/bindings/interface/SBHostOS.i
===================================================================
--- lldb/bindings/interface/SBHostOS.i
+++ lldb/bindings/interface/SBHostOS.i
@@ -27,22 +27,29 @@
     static lldb::SBFileSpec
     GetUserHomeDirectory ();
 
+
+    %feature("docstring", " .. deprecated:: 13 ") ThreadCreated;
     static void
     ThreadCreated (const char *name);
 
+    %feature("docstring", " .. deprecated:: 13 ") ThreadCreate;
     static lldb::thread_t
     ThreadCreate (const char *name,
                   lldb::thread_func_t,
                   void *thread_arg,
                   lldb::SBError *err);
 
+    %feature("docstring", " .. deprecated:: 13 ") ThreadCancel;
     static bool
     ThreadCancel (lldb::thread_t thread,
                   lldb::SBError *err);
 
+    %feature("docstring", " .. deprecated:: 13 ") ThreadDetach;
     static bool
     ThreadDetach (lldb::thread_t thread,
                   lldb::SBError *err);
+
+    %feature("docstring", " .. deprecated:: 13 ") ThreadJoin;
     static bool
     ThreadJoin (lldb::thread_t thread,
                 lldb::thread_result_t *result,



Index: lldb/include/lldb/API/SBHostOS.h
===================================================================
--- lldb/include/lldb/API/SBHostOS.h
+++ lldb/include/lldb/API/SBHostOS.h
@@ -24,15 +24,21 @@
 
   static lldb::SBFileSpec GetUserHomeDirectory();
 
+  /// \deprecated Deprecated since LLDB version 13.
   static void ThreadCreated(const char *name);
 
+  /// \deprecated Deprecated since LLDB version 13.
   static lldb::thread_t ThreadCreate(const char *name,
                                      lldb::thread_func_t thread_function,
                                      void *thread_arg, lldb::SBError *err);
 
+  /// \deprecated Deprecated since LLDB version 13.
   static bool ThreadCancel(lldb::thread_t thread, lldb::SBError *err);
 
+  /// \deprecated Deprecated since LLDB version 13.
   static bool ThreadDetach(lldb::thread_t thread, lldb::SBError *err);
+
+  /// \deprecated Deprecated since LLDB version 13.
   static bool ThreadJoin(lldb::thread_t thread, lldb::thread_result_t *result,
                          lldb::SBError *err);
 
Index: lldb/bindings/interface/SBHostOS.i
===================================================================
--- lldb/bindings/interface/SBHostOS.i
+++ lldb/bindings/interface/SBHostOS.i
@@ -27,22 +27,29 @@
     static lldb::SBFileSpec
     GetUserHomeDirectory ();
 
+
+    %feature("docstring", " .. deprecated:: 13 ") ThreadCreated;
     static void
     ThreadCreated (const char *name);
 
+    %feature("docstring", " .. deprecated:: 13 ") ThreadCreate;
     static lldb::thread_t
     ThreadCreate (const char *name,
                   lldb::thread_func_t,
                   void *thread_arg,
                   lldb::SBError *err);
 
+    %feature("docstring", " .. deprecated:: 13 ") ThreadCancel;
     static bool
     ThreadCancel (lldb::thread_t thread,
                   lldb::SBError *err);
 
+    %feature("docstring", " .. deprecated:: 13 ") ThreadDetach;
     static bool
     ThreadDetach (lldb::thread_t thread,
                   lldb::SBError *err);
+
+    %feature("docstring", " .. deprecated:: 13 ") ThreadJoin;
     static bool
     ThreadJoin (lldb::thread_t thread,
                 lldb::thread_result_t *result,

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits