mib added a comment. In D107585#2979988 <https://reviews.llvm.org/D107585#2979988>, @JDevlieghere wrote:
> Can you explain why we need the memory region? When we're using an SB class > from the ScriptedProcess plugin, we need to be very careful to avoid > introducing cyclic dependencies. The memory region seems like a pretty "dumb" > class (i.e. it's basically just a few ivars with getters and setters) so it's > probably fine, but we should have a comment explaining why it's fine. I mistakenly merge the changes for this patch and D108953 <https://reviews.llvm.org/D108953> on my previous diff ... Since your question is concerning that other patch, I'll follow-up there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107585/new/ https://reviews.llvm.org/D107585 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
