mib marked 2 inline comments as done. mib added inline comments.
================ Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:186 +void ScriptedThread::RefreshStateAfterStop() { + // TODO: Implement + if (m_reg_context_sp) ---------------- JDevlieghere wrote: > Still relevant? Yes. We might need to implement this when introducing execution control to Scripted Threads. ================ Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:205-206 + *reg_info, m_scripted_process.GetTarget().GetArchitecture()); + assert(m_register_info_sp->GetNumRegisters() > 0); + assert(m_register_info_sp->GetNumRegisterSets() > 0); + } ---------------- JDevlieghere wrote: > Does this assertion depend on "user-input"? In other words, can this be > triggered by not returning any registers from the interface? Yes, the user has to provide some basic register information to be able to parse it and use it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107585/new/ https://reviews.llvm.org/D107585 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits