JDevlieghere added inline comments.
================
Comment at: lldb/source/Core/Debugger.cpp:1624
+ if (!m_broadcaster.EventTypeHasListeners(Debugger::eBroadcastBitProgress)) {
+ listener_sp->StartListeningForEvents(&m_broadcaster,
----------------
labath wrote:
> labath wrote:
> > Why is this conditional on someone else listening for this event? We don't
> > e.g. suppress the "Thread #N" blurb if someone is listening for
> > eBroadcastBitThreadSelected
> (listening for this event **at a specific point in time**)
My reasoning was that I didn't want us to handle events if someone else already
is. What would be the canonical way to do this? Are you suggestion that we
check it in the loop/callback?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120972/new/
https://reviews.llvm.org/D120972
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
