labath added inline comments.
================
Comment at: lldb/source/Core/Debugger.cpp:1624
+ if (!m_broadcaster.EventTypeHasListeners(Debugger::eBroadcastBitProgress)) {
+ listener_sp->StartListeningForEvents(&m_broadcaster,
----------------
JDevlieghere wrote:
> labath wrote:
> > labath wrote:
> > > Why is this conditional on someone else listening for this event? We
> > > don't e.g. suppress the "Thread #N" blurb if someone is listening for
> > > eBroadcastBitThreadSelected
> > (listening for this event **at a specific point in time**)
> My reasoning was that I didn't want us to handle events if someone else
> already is. What would be the canonical way to do this? Are you suggestion
> that we check it in the loop/callback?
I think the canonical way is to not do that. :) Events (except eStateChanged
events) can go to multiple listeners and each one can handle them in his own
way.
And there already is a setting controlling whether to print them, so anyone not
interested can turn them off that way.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120972/new/
https://reviews.llvm.org/D120972
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
