JDevlieghere added inline comments.
================ Comment at: lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/CMakeLists.txt:3 + Support + ObjectYAML + ) ---------------- I assume we don't need this anymore if we're using the dummy target? ================ Comment at: lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/CMakeLists.txt:21 + COMMENT "Running the LLDB command interpreter fuzzer..." + COMMAND cd ${CMAKE_CURRENT_SOURCE_DIR} && $<TARGET_FILE:lldb-commandinterpreter-fuzzer> -dict=inputdictionary.txt -only_ascii=1 + USES_TERMINAL ---------------- Shouldn't we use an absolute path for the input dictionary? Something like `${CMAKE_CURRENT_SOURCE_DIR}/inputdictionary.txt` ================ Comment at: lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/lldb-commandinterpreter-fuzzer.cpp:44 + if (thisinterpreter.IsValid()) { + thisinterpreter.HandleCommand("breakpoint set --name main", ro, false); + thisinterpreter.HandleCommand(str.c_str(), ro, false); ---------------- Why do we need a breakpoint? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128292/new/ https://reviews.llvm.org/D128292 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits