labath added a comment.

Thank you, Martin and Alvin for trying this out. Setting `LLDB_USE_LLDB_SERVER` 
definitely increases the number of tests that use lldb-server, but I wouldn't 
really say it's necessary, as I would expect that a change like this either 
works, or fails spectacularly.

Can I assume that you are ok with checking this in?

In D131159#3709965 <https://reviews.llvm.org/D131159#3709965>, @labath wrote:

> As for performance, it's definitely slower than not creating the events every 
> time around, but I doubt that difference would be noticeable. However, now 
> that I think about it, I think the repeating the call to `WSAEventSelect` 
> should be sufficient to get the level-triggered behavior, even if it's just 
> reusing the same event object. Let me try how that works.

I have implemented this now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131159/new/

https://reviews.llvm.org/D131159

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to