mstorsjo added a comment. In D131159#3742370 <https://reviews.llvm.org/D131159#3742370>, @labath wrote:
> In D131159#3742364 <https://reviews.llvm.org/D131159#3742364>, @mgorny wrote: > >> In D131159#3742235 <https://reviews.llvm.org/D131159#3742235>, @mstorsjo >> wrote: >> >>> (They're only used in asserts.) I guess we should add void casts to mark >>> the variables as used outside of asserts. >> >> Actually, there's a dedicated `UNUSED_IF_ASSERT_DISABLED` macro for that. >> Please use it instead. > > One of these days, I'm going to have to delete it. If void casts are good > enough for the rest of llvm, I don't see why should we be any different. Ok, so is this discussion settled and I can go ahead and use void casts for these trivial fixups? (I usually just push such patches directly without passing via review.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131159/new/ https://reviews.llvm.org/D131159 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
