aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land.
Small nitpicks, otherwise good! ================ Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxRangesRefView.cpp:41 +private: + lldb::ValueObjectSP m_range_sp = nullptr; ///< Pointer to the dereferenced + ///< __range_ member ---------------- Personally I prefer ``` ///Pointer to the dereferenced __range_ member. lldb::ValueObjectSP m_range_sp = nullptr; ``` for longer comments. ================ Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxRangesRefView.cpp:55 + return 1; +} + ---------------- I wonder if it would be more readable to move those one-line function definitions into the declaration? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138558/new/ https://reviews.llvm.org/D138558 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
