Michael137 marked an inline comment as done. Michael137 added inline comments.
================ Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxRangesRefView.cpp:41 +private: + lldb::ValueObjectSP m_range_sp = nullptr; ///< Pointer to the dereferenced + ///< __range_ member ---------------- aprantl wrote: > Personally I prefer > ``` > ///Pointer to the dereferenced __range_ member. > lldb::ValueObjectSP m_range_sp = nullptr; > ``` > for longer comments. Done ================ Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxRangesRefView.cpp:55 + return 1; +} + ---------------- aprantl wrote: > I wonder if it would be more readable to move those one-line function > definitions into the declaration? Looks better, done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138558/new/ https://reviews.llvm.org/D138558 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
