DavidSpickett planned changes to this revision.
DavidSpickett added a comment.

> I can't test it on macOS platforms because the bots won't be able to build & 
> run arm64e (ARMv8.3 w/ ptrauth) binaries. :/

Well our bots can't either but I've got QEMU locally is what I mean. We can run 
top byte ignore tests but top byte ignore being ignored by hardware sometimes 
makes tests pass anyway :)

> I don't have an opinion about whether we should also do it in 
> GetBreakableLoadAddress

I'll make a list of the paths to setting a breakpoint, to see which layer it 
makes the most sense to fix in. (which I'll get time to do sometime in January)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136938/new/

https://reviews.llvm.org/D136938

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to