jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed.
It doesn't seem unreasonable that in the course of time we'll come across another circumstance where it's not worth deallocating these memory regions (for instance, we really don't need to do that if we're planning to kill the process). So it seems awkward to encode this particular reason in the Memory::Clear function. I think it would be better to have the parameter be "deallocate_memory", and then move the comment to Process::DidExec. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140249/new/ https://reviews.llvm.org/D140249 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
