jingham requested changes to this revision.
jingham added inline comments.
This revision now requires changes to proceed.
================
Comment at: lldb/bindings/python/python-typemaps.swig:57
+%typemap(out) void* {
+ $result = nullptr;
----------------
Won't this make every out void * claim to be a Python Object in the SWIG-ed
output? That seems dangerous. Maybe you should make a typedef
"LLDBScriptObjectPointer" or whatever, and that's what the SB API returns.
Then you could bind to that in the SWIG type map.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143236/new/
https://reviews.llvm.org/D143236
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
