JDevlieghere accepted this revision.
JDevlieghere added a comment.
I'd call it `GetScriptedImplementation()` to make it clear this isn't going to
give you the underlying `lldb_private` class or anything like that.
What happens in Python when you don't have a scripted implementation? Is the
result `None`? Let's add a test for that too.
Besides that this LGTM.
================
Comment at: lldb/bindings/python/python-typemaps.swig:59-62
+ const void* impl = $1;
+ if (impl) {
+ $result = (PyObject*) impl;
+ }
----------------
```
if (const void* impl = $1)
$result = (PyObject*) impl;
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143236/new/
https://reviews.llvm.org/D143236
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
