JDevlieghere added inline comments.
================
Comment at: lldb/include/lldb/Core/Debugger.h:594
lldb::TargetSP m_dummy_target_sp;
+ Diagnostics::CallbackID m_diagnostics_callback_id;
----------------
clayborg wrote:
> I am guessing these changes are in Debugger.h and Debugger.cpp are not
> related to this diff?
Yup. This got unintentionally mixed with D135631.
================
Comment at: lldb/source/Symbol/Symbol.cpp:780-781
+
+bool fromJSON(const llvm::json::Value &value, lldb_private::JSONSymbol &symbol,
+ llvm::json::Path path) {
+ llvm::json::ObjectMapper o(value, path);
----------------
clayborg wrote:
> Should this return an llvm::Expected<lldb_private::JSONSymbol> instead of a
> bool? Or is this fromJSON pattern used everywhere? Then we wouldn't need to
> fill in "path" and could return an error?
No, these are specializations/overloads for the JSON library in LLVM. Same
below.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145180/new/
https://reviews.llvm.org/D145180
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
