clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land.
Thanks for the changes! LGTM. Just one missed EXPECT_THAT_EXPECTED, but accepted. ================ Comment at: lldb/unittests/Symbol/JSONSymbolTest.cpp:144-145 + Expected<Symbol> symbol = Symbol::FromJSON(json_symbol, nullptr); + ASSERT_FALSE(static_cast<bool>(symbol)); + EXPECT_EQ(toString(symbol.takeError()), g_error_no_section_list); +} ---------------- Missed one EXPECT_THAT_EXPECTED. Feel free to fix and submit without approval. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145180/new/ https://reviews.llvm.org/D145180 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
