jasonmolenda added a comment.
This all looks good to me. the phab says there's a missing newline at the end
of TestXMLRegisterFlags.py.
Given that we can construct fake debug sessions with a gdb_remote_client test,
do you think it would be worth having a test that's says it's a big-endian
target, and confirming that we byte swap when the test is on a little-endian
host? I see you're using a .yaml shell binary for the session, but I wrote a
simple client test a while ago, TestStopPCs.py, where I don't even bother with
that.
On the other hand, I noticed you marked these as
`skipIfLLVMTargetMissing("AArch64")` - is this because of the clang types?
We're not disassembling or jitting anything for the target, as long as lldb
recognizes the triple/ArchSpec, for registers it seems like it should be fine?
If this skip is really needed, then I don't know how many people would exercise
an s390x test even if it was added - I don't personally build with that target
normally.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145580/new/
https://reviews.llvm.org/D145580
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
