DavidSpickett added a comment.

> Also, I realise that all this XML substitution with strings is very brittle. 
> I want to replace that with Python's xml.etree but will do that later in 
> another patch.

Having tried this, it gives you nice indentation but it's not that much 
different to the raw text. Except that you can't see exactly what's going in 
unless you turn on logging. It is useful to have example of the format here at 
a glance and I don't see there being too much churn in this file so I'm leaving 
it as is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145580/new/

https://reviews.llvm.org/D145580

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to