jgorbe added a comment.
I've tried building lldb with this patch applied and it fixes the problem I
saw. Thanks for the quick fix!
I'm not very familiar with the code so I'd appreciate if someone else gives
their LGTM too but the changes look reasonable to me (just one small nit I've
mentioned in an inline comment).
================
Comment at: lldb/source/DataFormatters/ValueObjectPrinter.cpp:278
- if (!m_options.m_hide_name) {
+ if (ShowName()) {
if (m_options.m_flat_output)
----------------
This method name reads like a command, rather than a predicate. What about
something like `ShouldShowName` or `ShouldPrintName`? This would also match the
style of other method names already in this file such as
`ShouldPrintValueObject`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146783/new/
https://reviews.llvm.org/D146783
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
