kastiglione added inline comments.
================
Comment at: lldb/source/DataFormatters/ValueObjectPrinter.cpp:278
- if (!m_options.m_hide_name) {
+ if (ShowName()) {
if (m_options.m_flat_output)
----------------
jgorbe wrote:
> This method name reads like a command, rather than a predicate. What about
> something like `ShouldShowName` or `ShouldPrintName`? This would also match
> the style of other method names already in this file such as
> `ShouldPrintValueObject`.
Good call, ShouldShowName is better.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146783/new/
https://reviews.llvm.org/D146783
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
