wallace added inline comments.
================
Comment at: lldb/cmake/modules/AddLLDB.cmake:173
+ if (LLDB_EXPORT_ALL_SYMBOLS)
+ if (CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU")
+ target_compile_options(${name} PRIVATE "-fvisibility=default")
----------------
rriddle wrote:
> Other places uses `if (NOT CMAKE_SYSTEM_NAME MATCHES "Windows")` to check for
> non-windows, should that check be used here as well? Not sure what's
> consistent for the lldb codebase.
I initially thought that it might be fine just to check the compiler id, but
better be safer gating the target OS as well.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147453/new/
https://reviews.llvm.org/D147453
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
