JDevlieghere added inline comments.
================
Comment at: lldb/cmake/modules/AddLLDB.cmake:175
+ CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU")
+ target_compile_options(${name} PRIVATE "-fvisibility=default")
+ endif()
----------------
Rather than changing the compile options directly, can we change the
`CXX_VISIBILITY_PRESET` property?
```
set_target_properties((${name} PROPERTIES CXX_VISIBILITY_PRESET default)
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147453/new/
https://reviews.llvm.org/D147453
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
