bulbazord added inline comments.
================
Comment at: lldb/source/Core/Disassembler.cpp:846
+ // Note: The reason we are making the data_type a uint64_t when value
is
+ // uint32_t is that there is no eTypeUInt32 enum value.
+ if (llvm::StringRef(value) == "uint32_t")
----------------
jingham wrote:
> That's kind of answering a question with a question: Why isn't there an
> eTypeUInt32?
I'm not sure, we'd have to ask Caroline who added this back in 2011. I added a
comment to help me remember, but I suppose this comment may add more confusion
than remove. I'll remove the note.
================
Comment at: lldb/source/Interpreter/OptionValueDictionary.cpp:39
- for (pos = m_values.begin(); pos != end; ++pos) {
+ for (auto pos = m_values.begin(), end = m_values.end(); pos != end; ++pos)
{
OptionValue *option_value = pos->second.get();
----------------
jingham wrote:
> Does the llvm::StringMap dingus not support `for (auto value : m_values) {` ?
Oh, it probably does. Didn't even think about it, good catch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149482/new/
https://reviews.llvm.org/D149482
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
