JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lldb/source/Core/Disassembler.cpp:805
 
-      ConstString const_key(key.c_str());
+      llvm::StringRef key_ref(key);
       // Check value to see if it's the start of an array or dictionary.
----------------
I don't think you need this: `key` is a `std::string` that can be used 
directly. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149482/new/

https://reviews.llvm.org/D149482

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to