That's an option too, which I considered. I went with this as a more conservative change. If there's agreement to remove it then I can change it.
On Thursday, June 1, 2023, Alex Langford via Phabricator < revi...@reviews.llvm.org> wrote: > bulbazord added a comment. > > If every caller sets this to true, why not remove the argument altogether? > It looks like `ValueObjectRegister::GetChildMemberWithName` doesn't use > the argument, `ValueObject::GetChildMemberWithName` and > `ValueObjectSynthetic::GetChildMemberWithName` just pass it along to > `GetChildAtIndex`. > > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D151966/new/ > > https://reviews.llvm.org/D151966 > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
