bulbazord accepted this revision.
bulbazord added a comment.
This revision is now accepted and ready to land.

Makes sense to me. Does it make sense to add a test case where we mix 
"printable" characters with "non-printable" ones? I see you have a `\f` at the 
end there, but that's a special escaped character. Something like 
`"\xef\xbb\xbfHello World!\n"`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153644/new/

https://reviews.llvm.org/D153644

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to