JDevlieghere added a comment.
In D153644#4444891 <https://reviews.llvm.org/D153644#4444891>, @jasonmolenda
wrote:
> It seems like this patch is really avoiding the sign extension of an int8_t
> to int32_t in the process of being passed to printf. By casting it to
> unsigned we've avoided the sign extension and getting the correct result, but
> it seems like you could have used a printf formatter like
> `s.Printf("\\x%2.2hhx", c);`. I'm not opposed to solving it this way, but
> the description of why it's being cast to unsigned is not really clear imo.
Good point. Went with that in c0045a8e8e0c72a0c8be3a9c333885da4d14d472.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153644/new/
https://reviews.llvm.org/D153644
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
