bulbazord added a comment. These uses of `LLDB_LOG` are taking errors, consuming them while turning them into strings, and logging them. Unless I'm missing something, I think it would make more sense to convert these to use `LLDB_LOG_ERROR`.
================ Comment at: lldb/source/Core/Debugger.cpp:1918-1919 } else { - LLDB_LOG(GetLog(LLDBLog::Host), "failed to launch host thread: {}", + LLDB_LOG(GetLog(LLDBLog::Host), "failed to launch host thread: {0}", llvm::toString(event_handler_thread.takeError())); } ---------------- Same here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154532/new/ https://reviews.llvm.org/D154532 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits