JDevlieghere added a comment.

In D154532#4474534 <https://reviews.llvm.org/D154532#4474534>, @bulbazord wrote:

> These uses of `LLDB_LOG` are taking errors, consuming them while turning them 
> into strings, and logging them. Unless I'm missing something, I think it 
> would make more sense to convert these to use `LLDB_LOG_ERROR`.

Good point, I blindly fixed the format specifiers without lookin what was being 
passed in.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154532/new/

https://reviews.llvm.org/D154532

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
  • [Lldb-commits]... Jonas Devlieghere via Phabricator via lldb-commits
    • [Lldb-com... Alex Langford via Phabricator via lldb-commits
    • [Lldb-com... Alex Langford via Phabricator via lldb-commits
    • [Lldb-com... Jonas Devlieghere via Phabricator via lldb-commits
    • [Lldb-com... Jonas Devlieghere via Phabricator via lldb-commits
    • [Lldb-com... Jonas Devlieghere via Phabricator via lldb-commits
    • [Lldb-com... Felipe de Azevedo Piovezan via Phabricator via lldb-commits
    • [Lldb-com... Felipe de Azevedo Piovezan via Phabricator via lldb-commits
    • [Lldb-com... Alex Langford via Phabricator via lldb-commits
    • [Lldb-com... Alex Langford via Phabricator via lldb-commits
    • [Lldb-com... Jonas Devlieghere via Phabricator via lldb-commits

Reply via email to