clayborg added a comment. Sorry this fell off my radar. I was on medical leave for a surgery for 3 months. Back now
================ Comment at: lldb/tools/lldb-vscode/Watchpoint.cpp:72 + m_verified = true; + m_error = ""; +} ---------------- ================ Comment at: lldb/tools/lldb-vscode/Watchpoint.cpp:90 + m_verified = false; + m_error = ""; +} ---------------- ================ Comment at: lldb/tools/lldb-vscode/Watchpoint.h:1 +//===-- Watchpoint.h --------------------------------------*- C++ -*-===// +// ---------------- Fix width of this comment to match line 7 ================ Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2449 + << " with size " << std::dec << v_size; + populate_data_breakpoint_info(response, data.str(), description.str(), error.Success() && region_info.IsReadable(), error.Success() && region_info.IsWritable()); + g_vsc.SendJSON(llvm::json::Value(std::move(response))); ---------------- Any line over 80 chars should be formatted to not exceed. Best to try and. use clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140630/new/ https://reviews.llvm.org/D140630 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
