bulbazord added a comment. In D157460#4571772 <https://reviews.llvm.org/D157460#4571772>, @mib wrote:
> Shouldn't this be next to the other `Stream` class in `lldbUtility` ? `lldbUtility` is the lowest layer and does not depend on anything in `lldbHost`. That being said, `StreamFile` uses `File` and `FileSystem` from `lldbHost`, so that is the lowest layer it can sit on without a layering violation. ================ Comment at: lldb/include/lldb/Host/StreamFile.h:12 #include "lldb/Host/File.h" #include "lldb/Utility/Stream.h" ---------------- mib wrote: > Do we really need this header ? We could forward declare FileSP do avoid > having to include it here We're actually using it in this header (look at `GetFile()`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157460/new/ https://reviews.llvm.org/D157460 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
