mib added inline comments.
================ Comment at: lldb/include/lldb/Host/StreamFile.h:12 #include "lldb/Host/File.h" #include "lldb/Utility/Stream.h" ---------------- bulbazord wrote: > mib wrote: > > Do we really need this header ? We could forward declare FileSP do avoid > > having to include it here > We're actually using it in this header (look at `GetFile()`). There is already a `GetFileSP` we could use that instead and remove `GetFile` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157460/new/ https://reviews.llvm.org/D157460 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
