llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) <details> <summary>Changes</summary> AddName gives no feedback other than if it succeeded whereas AddNameWithErrorHandling gives you back an SBError object. I would like to mark AddName as deprecated and direct folks to use AddNameWithErorrHandling instead. --- Full diff: https://github.com/llvm/llvm-project/pull/71228.diff 1 Files Affected: - (modified) lldb/include/lldb/API/SBBreakpoint.h (+1) ``````````diff diff --git a/lldb/include/lldb/API/SBBreakpoint.h b/lldb/include/lldb/API/SBBreakpoint.h index 0bb7c31d74f21f9..c7ef287a5a6f17b 100644 --- a/lldb/include/lldb/API/SBBreakpoint.h +++ b/lldb/include/lldb/API/SBBreakpoint.h @@ -112,6 +112,7 @@ class LLDB_API SBBreakpoint { SBError SetScriptCallbackBody(const char *script_body_text); + LLDB_DEPRECATED("Use AddNameWithErrorHandling instead") bool AddName(const char *new_name); SBError AddNameWithErrorHandling(const char *new_name); `````````` </details> https://github.com/llvm/llvm-project/pull/71228 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
